Skip to content

gh-149720: Remove support for undotted ext in mimetypes.MimeType.add_type#149721

Merged
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-149720
May 12, 2026
Merged

gh-149720: Remove support for undotted ext in mimetypes.MimeType.add_type#149721
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-149720

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented May 12, 2026

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 12, 2026

Documentation build overview

📚 cpython-previews | 🛠️ Build #32655283 | 📁 Comparing c3dbd0d against main (f5fb491)

  🔍 Preview build  

3 files changed
± library/mimetypes.html
± whatsnew/3.16.html
± whatsnew/changelog.html

Copy link
Copy Markdown
Contributor

@clin1234 clin1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes, it LGTM ;-)

Comment thread Lib/mimetypes.py Outdated
Comment thread Doc/library/mimetypes.rst Outdated
Comment thread Lib/test/test_mimetypes.py Outdated
Comment thread Lib/test/test_mimetypes.py Outdated
Copy link
Copy Markdown
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn enabled auto-merge (squash) May 12, 2026 13:18
@sobolevn sobolevn merged commit 0534774 into python:main May 12, 2026
56 checks passed
@StanFromIreland
Copy link
Copy Markdown
Member

Did we not have a PR for this already?

@StanFromIreland
Copy link
Copy Markdown
Member

Yes it was #2895.

Comment thread Doc/library/mimetypes.rst
When *strict* is ``True`` (the default), the mapping will be added to the
official MIME types, otherwise to the non-standard ones.

.. deprecated-removed:: 3.14 3.16
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also have a versionchanged like above?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch #149731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants