Skip to content

[3.14] gh-150175: Fix ThreadingMock call_count race condition (GH-150176) #150181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miss-islington wants to merge 1 commit into
base: 3.14
Choose a base branch
from
+7 −0
Open

[3.14] gh-150175: Fix ThreadingMock call_count race condition (GH-150176) #150181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/unittest/mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3121,6 +3121,10 @@ def _mock_call(self, *args, **kwargs):

return ret_value

def _increment_mock_call(self, /, *args, **kwargs):
with self._mock_calls_events_lock:
super()._increment_mock_call(*args, **kwargs)

def wait_until_called(self, *, timeout=_timeout_unset):
"""Wait until the mock object is called.

Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-05-21-11-25-58.gh-issue-150175.8H4Caz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix race condition in :class:`unittest.mock.ThreadingMock` where
concurrent calls could lose increments to ``call_count`` and other
attributes due to a missing lock in ``_increment_mock_call``.
Loading