gh-150522: anchor suffix check in http.cookiejar.domain_match#150523
Open
metsw24-max wants to merge 1 commit into
Open
gh-150522: anchor suffix check in http.cookiejar.domain_match#150523metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domain_match() computes A.rfind(B) but never checks the match sits at the end of A, so a host like www.acme.com.evil.org matches the cookie domain .acme.com even though it does not end with it. RFC 2965 wants A to have the form NB, and the sibling user_domain_match() already uses endswith. Anchor the rfind result to the end of A.