gh-150679: reject CR and LF in http.server send_header and send_response_only#150680
Closed
metsw24-max wants to merge 1 commit into
Closed
gh-150679: reject CR and LF in http.server send_header and send_response_only#150680metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
Member
|
This is known and documented. We are NOT going to fix this because people may want this behavior just for testing purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_header() and send_response_only() interpolate the keyword, value and reason phrase straight into the header and status lines, so a CR or LF reflected from a request injects extra headers or splits the response. http.client.putheader, wsgiref.headers and http.cookies already reject control characters here; these two writers were the holdouts. Reject CR and LF in the supplied arguments, matching the rest of the stdlib.