gh-150720: Remove '-d 1' in test_script_error_treatment#150736
Merged
Conversation
Fix race condition in test_script_error_treatment in test_sampling_profiler. An overloaded system can end up running the subprocess under the test so slowly that it never reaches the point of emitting the error message when the one second duration in the profiler expires. We can just drop the `-d 1` argument to let the profiler wait until the target process finishes.
pablogsal
approved these changes
Jun 1, 2026
pablogsal
added
awaiting review
needs backport to 3.15
Member
|
Thanks man 🖤🙏 |
|
Thanks @lkollar for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-150746 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition in test_script_error_treatment in test_sampling_profiler. An overloaded system can end up running the subprocess under the test so slowly that it never reaches the point of emitting the error message when the one second duration in the profiler expires. We can just drop the
-d 1argument to let the profiler wait until the target process finishes.