Skip to content

Add warning to Thread.run() docstring so that users are aware Thread.start() is the correct way to start a thread#150833

Open
radiantsb wants to merge 2 commits into
python:mainfrom
radiantsb:patch-1
Open

Add warning to Thread.run() docstring so that users are aware Thread.start() is the correct way to start a thread#150833
radiantsb wants to merge 2 commits into
python:mainfrom
radiantsb:patch-1

Conversation

@radiantsb
Copy link
Copy Markdown

add a warning to Thread.run() docstring so that users are aware that Thread.start() is the correct way to start a thread's execution

add a warning to Thread.run() docstring so that users are aware that Thread.start() is the correct way to start a thread's execution
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Jun 3, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 3, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the actual documentation.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 3, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@radiantsb
Copy link
Copy Markdown
Author

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 4, 2026

Thanks for making the requested changes!

@ZeroIntensity: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from ZeroIntensity June 4, 2026 06:41
@read-the-docs-community
Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32985976 | 📁 Comparing 21c2d79 against main (57d4446)

  🔍 Preview build  

1 file changed
± library/threading.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants