Add warning to Thread.run() docstring so that users are aware Thread.start() is the correct way to start a thread#150833
Add warning to Thread.run() docstring so that users are aware Thread.start() is the correct way to start a thread#150833radiantsb wants to merge 2 commits into
Conversation
add a warning to Thread.run() docstring so that users are aware that Thread.start() is the correct way to start a thread's execution
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Please also update the actual documentation.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ZeroIntensity: please review the changes made to this pull request. |
Documentation build overview
|
add a warning to Thread.run() docstring so that users are aware that Thread.start() is the correct way to start a thread's execution