gh-151947: Fix all Sphinx reference warnings in Doc/library/email.{charset,parser}.rst#151966
Open
lpyu001 wants to merge 2 commits into
Open
gh-151947: Fix all Sphinx reference warnings in Doc/library/email.{charset,parser}.rst#151966lpyu001 wants to merge 2 commits into
Doc/library/email.{charset,parser}.rst#151966lpyu001 wants to merge 2 commits into
Conversation
Documentation build overview
|
lpyu001
requested review from
AA-Turner,
StanFromIreland and
hugovk
as code owners
| more information on what else *policy* controls, see the | ||
| :mod:`~email.policy` documentation. | ||
|
|
||
| Note: **The policy keyword should always be specified**; The default will |
Member
There was a problem hiding this comment.
Suggested change
| Note: **The policy keyword should always be specified**. The default will |
| Conversions will proceed from input charset, to Unicode, to the output charset | ||
| when the method :meth:`Charset.convert` is called. The default is to output in | ||
| the same character set as the input. | ||
| when the method :meth:`!Charset.convert` is called. The default is to output |
Member
There was a problem hiding this comment.
This is masking a real bug. We can replace it with a reference to Charset.body_encode. You'll also have to make the same change to the docstring:
Lines 153 to 155 in ad38cf8
StanFromIreland
changed the title
Doc/library/email.{charset,parser}.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-->
Doc/library/email.{charset,parser}.rst#151947