gh-152297: Reify dotted lazy imports with the full dotted name#152307
Open
Kuhai9801 wants to merge 1 commit into
Open
gh-152297: Reify dotted lazy imports with the full dotted name#152307Kuhai9801 wants to merge 1 commit into
Kuhai9801 wants to merge 1 commit into
Conversation
85a1a27 to
e2f3da0
Compare
e2f3da0 to
18ced5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lazy reification for dotted imports so
lazy import pkg.subcalls__import__with the full dotted name, matching eager import behavior.The regression tests cover custom
__import__hooks and first-use loading of the dotted target.Tests:
git diff --check