gh-152486: Fix force_zip64 not honored when writing central directory#152493
Open
danny0838 wants to merge 5 commits into
Open
gh-152486: Fix force_zip64 not honored when writing central directory#152493danny0838 wants to merge 5 commits into
force_zip64 not honored when writing central directory#152493danny0838 wants to merge 5 commits into
Conversation
danny0838
changed the title
force_zip64 not honored when writing central directoryforce_zip64 not honored when writing central directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where
force_zip64is not honored when writing to the central directory.ZipFile.open(force_zip64=True)generates inconsistent zip64 extra fields #152486