gh-152431: Update StreamReader transport after asyncio TLS upgrade#152509
Closed
factnn wants to merge 2 commits into
Closed
gh-152431: Update StreamReader transport after asyncio TLS upgrade#152509factnn wants to merge 2 commits into
factnn wants to merge 2 commits into
Conversation
StreamReaderProtocol._replace_transport only updated its own transport reference. After start_tls, the linked StreamReader still held the old transport, causing reads to use the wrong connection.
factnn
requested review from
1st1,
asvetlov,
gpshead,
kumaraditya303,
picnixz and
willingc
as code owners
picnixz
reviewed
Jun 28, 2026
Member
|
Actually there is already a PR for that. Please don't open duplicated PRs. |
Member
|
I just noticed this, @factnn this is the second such PR in the same hour. If this noise continues we will be forced to restrict your account in the Python organisation. |
Author
|
thanks for pointing that out — I didn't notice #152432. closing this as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152431
StreamReaderProtocol._replace_transportonly updated its owntransport reference. After
start_tls, the linkedStreamReaderstill held the old transport, causing reads touse the wrong connection.