Skip to content

gh-151029: Fix test_remote_exec_deleted_static_executable on static installed builds#152653

Merged
encukou merged 1 commit into
python:mainfrom
StanFromIreland:test_remote_exec_deleted_static_executable
Jun 30, 2026
Merged

gh-151029: Fix test_remote_exec_deleted_static_executable on static installed builds#152653
encukou merged 1 commit into
python:mainfrom
StanFromIreland:test_remote_exec_deleted_static_executable

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

test_remote_exec_deleted_static_executable (from gh-151029) rebuilds a fake build-tree and symlinks the stdlib via srcdir/Lib, but on an installed Python sysconfig's srcdir points at the config-* directory (which has no Lib/). The copied interpreter then can't find the stdlib, so it dies at startup before connecting (server_socket.accept() hangs until it raises TimeoutError). Failed run, for example.

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jun 30, 2026
@StanFromIreland StanFromIreland changed the title Fix test_remote_exec_deleted_static_executable on static installed … gh-151029: Fix test_remote_exec_deleted_static_executable on static installed builds Jun 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 30, 2026
Closed
@StanFromIreland

StanFromIreland commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

!buildbot installed|riscv64

(Note: The RISC-V buildbot runs a static installed build, but it just doesn’t have it in the name)

@bedevere-bot

bedevere-bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit a2bf789 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152653%2Fmerge

The command will test the builders whose names match following regular expression: installed|riscv64

The builders matched are:

  • aarch64 CentOS10 Clang Installed PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • AMD64 Fedora Stable Clang Installed PR
  • riscv64 Ubuntu23 PR
  • s390x Fedora Stable Clang Installed PR
  • x86 Debian Installed with X PR
  • aarch64 Fedora Stable Clang Installed PR
  • s390x Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Stable Clang Installed PR
  • AMD64 Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Rawhide Clang Installed PR

encukou
encukou reviewed Jun 30, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Out-of-tree builds strike again.
Thanks for looking into this!

+1 if buildbots are green. (I don't know if this is the best way to do things, but it looks OK to me, and unbreaking buildbots is an improvement.)

@StanFromIreland

StanFromIreland commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thanks for the review. I did consider just skipping it in this case, but the Lib/os.py workaround isn't too messy.

Fix confirmed, e.g. x86 Debian Installed with X 3.x which has been consistently failing on the test now passes. I'll wait till they all run.

This was referenced Jun 30, 2026
Closed
Open
@encukou encukou merged commit 03efeef into python:main Jun 30, 2026
61 checks passed
@encukou encukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 30, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

GH-152669 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 30, 2026
@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

GH-152670 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 30, 2026
@StanFromIreland StanFromIreland deleted the test_remote_exec_deleted_static_executable branch June 30, 2026 10:48
StanFromIreland added a commit that referenced this pull request Jun 30, 2026
@miss-islington @StanFromIreland
[3.15] gh-151029: Fix test_remote_exec_deleted_static_executable on…
eebdbfd 
… static installed builds (GH-152653) (#152670)

(cherry picked from commit 03efeef)

Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Jun 30, 2026
@miss-islington @StanFromIreland
[3.14] gh-151029: Fix test_remote_exec_deleted_static_executable on…
940be2e 
… static installed builds (GH-152653) (#152669)

(cherry picked from commit 03efeef)

Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@ambv ambv Awaiting requested review from ambv
@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @bedevere-bot @encukou