gh-153169: Look through marks in the regex alternation quick check#153170
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-153169: Look through marks in the regex alternation quick check#153170serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
The BRANCH quick check skips an alternative whose first literal or character set cannot match the current character, but only when it is the very first op, so alternatives starting with a capturing group or with a repeat with a nonzero minimum were never skipped. Look through MARK ops and into the repeated item. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BRANCH quick check skips an alternative whose first literal or character set cannot match the current character, but only when it is the very first op. Look through MARK ops and into a repeat of one item with a nonzero minimum, so alternatives starting with a capturing group or such a repeat are also skipped without entering. The existing checks are performed first and unchanged, so plain alternations are unaffected.
Benchmarks in the issue.