Skip to content

Add comment to avoid ACKS losing order #17678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add comment to avoid ACKS losing order #17678

merged 1 commit into from
Dec 23, 2019

Conversation

@merwok
Copy link
Member

@merwok merwok commented Dec 21, 2019

tirkarthi
tirkarthi approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@merwok merwok changed the title Add comment to avoid ACKS losing order Add comment to avoid ACKS losing order (GH-17678) Dec 23, 2019
@merwok merwok merged commit 3c75f31 into master Dec 23, 2019
@merwok merwok deleted the misc-acks-comment branch December 23, 2019 17:03
@merwok merwok changed the title Add comment to avoid ACKS losing order (GH-17678) Add comment to avoid ACKS losing order Dec 23, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@merwok @shihai1991
Add comment to avoid ACKS losing order (pythonGH-17678)
90b1004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@merwok @tirkarthi @the-knights-who-say-ni @bedevere-bot