bpo-39189: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again#17736
bpo-39189: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again#17736GreatBahram wants to merge 3 commits into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
@GreatBahram, thank you for the contribution! Please open a ticket on bugs.python.org for this issue. Even though it's a small change, having a ticket on the bug tracker gives higher visibility to items and a better chance for it to be reviewed. Also, please signed the CLA as requested by the bot. Thanks! |
|
Hi, Thanks for the explanation, I signed as it was explained and also opened an issue for this purpose: https://bugs.python.org/issue39189 Is there anything else? |
|
@GreatBahram can you alter the title with |
|
@bedevere-bot accidentally edited my original message, ignore that and check the original one from edit history. |
|
Anything else? |
|
@GreatBahram, thank you. The bot isn't finding that you signed the CLA; I think you need to add your Github user name to your bug tracker account in order for it to be able to match it. Thanks! |
|
Yeah, the objection you mentioned was the problem. Thanks |

Hello there,
This Pull Request replaces the BUFSIZE variable with the existing one inside the
iomodule.Explanation:
I just removed the BUFSIZE global variable and replaced it with the io.DEFAULT_BUFFER_SIZE variable.
I couldn't find an open issue for this, but I do believe it does not need one, as it is a trivial issue!
I checked other branches, this problem affects below branches as well.
https://bugs.python.org/issue39189