Skip to content

bpo-39189: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again#17736

Closed
GreatBahram wants to merge 3 commits into
python:masterfrom
GreatBahram:master
Closed

bpo-39189: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again#17736
GreatBahram wants to merge 3 commits into
python:masterfrom
GreatBahram:master

Conversation

@GreatBahram
Copy link
Copy Markdown

@GreatBahram GreatBahram commented Dec 29, 2019

Hello there,

This Pull Request replaces the BUFSIZE variable with the existing one inside the io module.

Explanation:

I just removed the BUFSIZE global variable and replaced it with the io.DEFAULT_BUFFER_SIZE variable.

I couldn't find an open issue for this, but I do believe it does not need one, as it is a trivial issue!

I checked other branches, this problem affects below branches as well.

https://bugs.python.org/issue39189

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@GreatBahram

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link
Copy Markdown
Contributor

@GreatBahram, thank you for the contribution! Please open a ticket on bugs.python.org for this issue. Even though it's a small change, having a ticket on the bug tracker gives higher visibility to items and a better chance for it to be reviewed. Also, please signed the CLA as requested by the bot. Thanks!

@GreatBahram
Copy link
Copy Markdown
Author

Hi,

Thanks for the explanation, I signed as it was explained and also opened an issue for this purpose:

https://bugs.python.org/issue39189

Is there anything else?

@isidentical
Copy link
Copy Markdown
Member

isidentical commented Jan 2, 2020

@GreatBahram can you alter the title with [bpo-39199](https://bugs.python.org/issue39199): <message>

@GreatBahram GreatBahram changed the title Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again bpo-39199: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again Jan 2, 2020
@GreatBahram GreatBahram changed the title bpo-39199: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again [bpo-39199] (https://bugs.python.org/issue39199): Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again Jan 2, 2020
@GreatBahram GreatBahram changed the title [bpo-39199] (https://bugs.python.org/issue39199): Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again [bpo-39199](https://bugs.python.org/issue39199): Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again Jan 2, 2020
@isidentical
Copy link
Copy Markdown
Member

@bedevere-bot accidentally edited my original message, ignore that and check the original one from edit history.
image

@GreatBahram GreatBahram changed the title [bpo-39199](https://bugs.python.org/issue39199): Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again bpo-39199: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again Jan 3, 2020
@GreatBahram
Copy link
Copy Markdown
Author

Anything else?

@csabella csabella changed the title bpo-39199: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again bpo-39189: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again Jan 5, 2020
@csabella
Copy link
Copy Markdown
Contributor

csabella commented Jan 5, 2020

@GreatBahram, thank you. The bot isn't finding that you signed the CLA; I think you need to add your Github user name to your bug tracker account in order for it to be able to match it. Thanks!

@GreatBahram
Copy link
Copy Markdown
Author

Yeah, the objection you mentioned was the problem.

Thanks

@csabella csabella requested review from benjaminp and methane and removed request for benjaminp May 28, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants