Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 9, 2020

  • Add test cases for dataclasses.

  • Add test for repr output of field.

  • Add test for ValueError to be raised when both default and default_factory are passed.
    (cherry picked from commit eef1b02)

Co-authored-by: Karthikeyan Singaravelan tir.karthi@gmail.com

Automerge-Triggered-By: @ericvsmith

* Add test cases for dataclasses.

* Add test for repr output of field.
* Add test for ValueError to be raised when both default and default_factory are passed.
(cherry picked from commit eef1b02)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@miss-islington
Copy link
Contributor Author

@tirkarthi and @ericvsmith: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@tirkarthi and @ericvsmith: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@tirkarthi and @ericvsmith: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit df2fb60 into python:3.8 Jan 10, 2020
@miss-islington miss-islington deleted the backport-eef1b02-3.8 branch January 10, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants