Skip to content

bpo-39205: Tests that highlight a hang on ProcessPoolExecutor shutdown #18221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2020
Merged

bpo-39205: Tests that highlight a hang on ProcessPoolExecutor shutdown #18221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c07ddd0
Add a test for a hang at exit
brianquinlan Jan 27, 2020
7b5d53a
Add a message for skip
brianquinlan Jan 27, 2020
e8b6a06
Remove incorrect comment
brianquinlan Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Lib/test/test_concurrent_futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,26 @@ def test_hang_issue12364(self):
for f in fs:
f.result()

def test_hang_issue39205(self):
"""shutdown(wait=False) doesn't hang at exit with running futures.

See https://bugs.python.org/issue39205.
"""
if self.executor_type == futures.ProcessPoolExecutor:
raise unittest.SkipTest(
"Hangs due to https://bugs.python.org/issue39205")

rc, out, err = assert_python_ok('-c', """if True:
from concurrent.futures import {executor_type}
from test.test_concurrent_futures import sleep_and_print
if __name__ == "__main__":
t = {executor_type}(max_workers=3)
t.submit(sleep_and_print, 1.0, "apple")
t.shutdown(wait=False)
""".format(executor_type=self.executor_type.__name__))
self.assertFalse(err)
self.assertEqual(out.strip(), b"apple")


class ThreadPoolShutdownTest(ThreadPoolMixin, ExecutorShutdownTest, BaseTestCase):
def _prime_executor(self):
Expand Down