New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-12383: Refactor subprocess test_empty_env #1874

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
3 participants
@gpshead
Member

gpshead commented May 30, 2017

Bugfix: This test wasn't being run because it was skipping based on the
presence of Py_ENABLE_SHARED rather than its value. It is always present
on POSIX systems but defaults to 0.

Refactoring: Move the environment variables that can be ignored into a
function. Parse the list from the child process and filter out the ones
to exclude in the parent before checking that the rest is empty.

Feature: Adds always present environment variables to ignore when
running in a Gentoo sandbox so that the test can pass there.

bpo-12383: Refactor test_empty_env for robustness.
Bugfix: This test wasn't being run because it was skipping based on the
presence of Py_ENABLE_SHARED rather than its value.  It is always present
on POSIX systems but defaults to 0.

Refactoring: Move the environment variables that can be ignored into a
function.  Parse the list from the child process and filter out the ones
to exclude in the parent before checking that the rest is empty.

Feature: Adds always present environment variables to ignore when
running in a Gentoo sandbox so that the test can pass there.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 30, 2017

@gpshead, thanks for your PR! By analyzing the history of the files in this pull request, we identified @florentx, @tiran and @vadmium to be potential reviewers.

mention-bot commented May 30, 2017

@gpshead, thanks for your PR! By analyzing the history of the files in this pull request, we identified @florentx, @tiran and @vadmium to be potential reviewers.

@gpshead gpshead merged commit b351248 into python:master May 30, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
bedevere/issue-number Issue number 12383 found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gpshead gpshead deleted the gpshead:test_subprocess_empty_env branch May 30, 2017

mlouielu added a commit to mlouielu/cpython that referenced this pull request Jun 15, 2017

bpo-12383: Refactor subprocess test_empty_env (#1874)
Bugfix: This test wasn't being run because it was skipping based on the
presence of Py_ENABLE_SHARED rather than its value.  It is always present
on POSIX systems but defaults to 0.

Refactoring: Move the environment variables that can be ignored into a
function.  Parse the list from the child process and filter out the ones
to exclude in the parent before checking that the rest is empty.

Feature: Adds always present environment variables to ignore when
running in a Gentoo sandbox so that the test can pass there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment