Skip to content

bpo-26067: Do not fail test_shutil / chown when gid/uid cannot be resolved #19032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2020
Merged

bpo-26067: Do not fail test_shutil / chown when gid/uid cannot be resolved #19032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dba00e
bpo-26067: Do not fail test_shutil.chown when gid/uid cannot be resolved
MatzeB Mar 16, 2020
4649de4
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 16, 2020
ab60c53
Address review feedback
MatzeB Mar 16, 2020
6b2d95e
address review feedback correctly
MatzeB Mar 16, 2020
ba16667
fix typo
MatzeB Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions Lib/test/test_shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,12 +1666,17 @@ def check_chown(path, uid=None, gid=None):
shutil.chown(dirname, group=gid)
check_chown(dirname, gid=gid)

user = pwd.getpwuid(uid)[0]
group = grp.getgrgid(gid)[0]
shutil.chown(filename, user, group)
check_chown(filename, uid, gid)
shutil.chown(dirname, user, group)
check_chown(dirname, uid, gid)
try:
user = pwd.getpwuid(uid)[0]
group = grp.getgrgid(gid)[0]
except KeyError:
# On some systems uid/gid cannot be resolved.
pass
else:
shutil.chown(filename, user, group)
check_chown(filename, uid, gid)
shutil.chown(dirname, user, group)
check_chown(dirname, uid, gid)


class TestWhich(BaseTest, unittest.TestCase):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2020-03-16-20-54-55.bpo-26067.m18_VV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not fail test_shutil test_chown test when uid or gid of user cannot be resolved to a name.