Skip to content

Fix typo from Lib/asyncio/events.py#19410

Merged
corona10 merged 1 commit intopython:masterfrom
wudenggang:typo-fix
Apr 14, 2020
Merged

Fix typo from Lib/asyncio/events.py#19410
corona10 merged 1 commit intopython:masterfrom
wudenggang:typo-fix

Conversation

@wudenggang
Copy link
Copy Markdown
Contributor

#typo fix : system

@wudenggang wudenggang requested review from 1st1 and asvetlov as code owners April 7, 2020 15:11
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@wudenggang

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@corona10
Copy link
Copy Markdown
Member

corona10 commented Apr 7, 2020

Thanks for the contribution, but please sign up the CLA first :)

Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@wudenggang
Copy link
Copy Markdown
Contributor Author

I have signed: "Contributor Agreement"

Copy link
Copy Markdown
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi
Copy link
Copy Markdown
Member

test__xxsubinterpreters failure doesn't seem to be related to this PR. Closing and opening the PR to trigger a rebuild.

@tirkarthi tirkarthi closed this Apr 12, 2020
@tirkarthi tirkarthi reopened this Apr 12, 2020
@tirkarthi
Copy link
Copy Markdown
Member

Build is successful. @corona10 would you like to merge this PR?

Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@tirkarthi Since I am in post mentoring period, I will merge the PR in 3 days :)
cc @vstinner

@corona10 corona10 merged commit 02152b7 into python:master Apr 14, 2020
@corona10 corona10 changed the title typo fix : system Fix typo from Lib/asyncio/events.py Apr 14, 2020
@corona10
Copy link
Copy Markdown
Member

corona10 commented Apr 14, 2020

@wudenggang
Thank you for contributing to the CPython project.
Now your PR is merged, I merged your PR with changing title ;)

@wudenggang wudenggang deleted the typo-fix branch April 14, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants