Update ga_new to use _PyArg_CheckPositional and _PyArg_NoKwnames #19679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Apr 23, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks! I hope you’ll try to implement a cache next.
Member
Author
I will try it! Thanks |
Member
|
@corona10: Oh, I didn't notice that this PR has no bpo associated with. You could reuse https://bugs.python.org/issue40369 since your change was initially proposed here, as part of a larger change. I like to link commits to bpo which provide more context. Sometimes, it's not worth it to create an issue just for a small cleanup change. Don't worry, it's not a big deal. It's just a minor remark for your future changes ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.