Skip to content

fix typo in warning #20620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2021
Merged

fix typo in warning #20620

merged 2 commits into from
Apr 25, 2021

Conversation

@aboddie
Copy link
Contributor

@aboddie aboddie commented Jun 3, 2020

Add space after period.

Current warning:
InvalidTZPathWarning: Invalid paths specified in PYTHONTZPATH environment variable.Paths should be absolute but found the following relative paths: ...

@aboddie
Add space after period to warning in _tzpath.py
160ad06 
Currently:
InvalidTZPathWarning: Invalid paths specified in PYTHONTZPATH environment variable.Paths should be absolute but found the following relative paths: ...
@tirkarthi tirkarthi requested a review from pganssle June 5, 2020 04:11
remilapeyre
remilapeyre suggested changes Jun 5, 2020
View reviewed changes
remilapeyre
remilapeyre approved these changes Jun 5, 2020
View reviewed changes
Copy link

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

remilapeyre
remilapeyre approved these changes Jul 20, 2020
View reviewed changes
Copy link

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orsenthil orsenthil merged commit a31cf86 into python:master Apr 25, 2021
@bedevere-bot
Copy link

bedevere-bot commented Apr 25, 2021

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Apr 25, 2021

Thanks @aboddie for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 25, 2021

Thanks @aboddie for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 25, 2021

Sorry, @aboddie and @orsenthil, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a31cf86bc2d9c0738b2a0251af766d6b247683fc 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Apr 25, 2021

Sorry @aboddie and @orsenthil, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a31cf86bc2d9c0738b2a0251af766d6b247683fc 3.9

@bedevere-bot
Copy link

bedevere-bot commented Apr 25, 2021

GH-25601 is a backport of this pull request to the 3.9 branch.

orsenthil added a commit that referenced this pull request Apr 25, 2021
@orsenthil @aboddie
[3.9] fix typo in warning (GH-20620) (#25601)
d2e2534 
* Add space after period to warning in _tzpath.py

Currently:
InvalidTZPathWarning: Invalid paths specified in PYTHONTZPATH environment variable.Paths should be absolute but found the following relative paths: ...

* Update _tzpath.py
(cherry picked from commit a31cf86)

Co-authored-by: Allen <64019758+aboddie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes

@pganssle pganssle Awaiting requested review from pganssle

+1 more reviewer

@remilapeyre remilapeyre remilapeyre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@orsenthil orsenthil

Labels

awaiting merge skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aboddie @bedevere-bot @miss-islington @orsenthil @remilapeyre @tirkarthi @the-knights-who-say-ni