Skip to content

add a missing period in json module's command lines options' documentation #21819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

add a missing period in json module's command lines options' documentation #21819

merged 1 commit into from
Aug 20, 2020

Conversation

@deronnax
Copy link
Contributor

@deronnax deronnax commented Aug 10, 2020

All other command lines options sections end with a dot.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 10, 2020
@deronnax deronnax mentioned this pull request Aug 10, 2020
Merged
awecx
awecx approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@deronnax deronnax changed the title add a missing period in command lines options of the json module add a missing period in json module's command lines options documentation Aug 10, 2020
@deronnax deronnax changed the title add a missing period in json module's command lines options documentation add a missing period in json module's command lines options' documentation Aug 10, 2020
facundobatista
facundobatista approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, we love consistency, thanks!

@JulienPalard JulienPalard reopened this Aug 20, 2020
@JulienPalard
Copy link
Member

JulienPalard commented Aug 20, 2020

(close/reopen to restart travis that failed to report a success :()

@JulienPalard JulienPalard merged commit 12695f4 into python:master Aug 20, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2020

Thanks @deronnax for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2020

Thanks @deronnax for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 20, 2020

GH-21932 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2020

Sorry, @deronnax and @JulienPalard, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 12695f4c6d1167c0863098a586f3dfeb77a7cb9a 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 20, 2020
@deronnax @miss-islington
Doc: add a missing period (pythonGH-21819)
9276ba4 
(cherry picked from commit 12695f4)

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2020

Thanks @deronnax for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2020

Sorry @deronnax and @JulienPalard, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 12695f4c6d1167c0863098a586f3dfeb77a7cb9a 3.8

facundobatista pushed a commit that referenced this pull request Aug 20, 2020
@miss-islington @deronnax
Doc: add a missing period (GH-21819) (#21932)
3949827 
(cherry picked from commit 12695f4)

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
@facundobatista
Copy link
Member

facundobatista commented Aug 20, 2020

Ah, my bad, this functionality is not in 3.8, I misread before. So, no need to backport there. \o/

@deronnax deronnax deleted the library_json_rst_missing_period branch August 20, 2020 21:03
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@deronnax
Doc: add a missing period (pythonGH-21819)
784161e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facundobatista facundobatista facundobatista approved these changes

+1 more reviewer

@awecx awecx awecx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JulienPalard JulienPalard

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@deronnax @JulienPalard @miss-islington @bedevere-bot @facundobatista @awecx @tirkarthi @the-knights-who-say-ni