Skip to content

Document that test.support.bytecode_helper is new in 3.9 #22618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Document that test.support.bytecode_helper is new in 3.9 #22618

merged 1 commit into from
Oct 15, 2020

Conversation

@gousaiyang
Copy link
Contributor

@gousaiyang gousaiyang commented Oct 9, 2020

Add versionadded directive to test.support.bytecode_helper documentation.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 9, 2020
tirkarthi
tirkarthi reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

nanjekyejoannah
nanjekyejoannah approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanjekyejoannah nanjekyejoannah merged commit cf693e5 into python:master Oct 15, 2020
@gousaiyang gousaiyang deleted the bytecode_helper-39-doc branch October 15, 2020 19:06
@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Oct 15, 2020

Thanks, @gousaiyang for the contribution.

@gousaiyang
Copy link
Contributor Author

gousaiyang commented Oct 15, 2020

Do we need to backport this to 3.9?

@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Oct 15, 2020

I suspect but I usually want to ping @ambv . Let us see if he has an opinion

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@gousaiyang
Document that test.support.bytecode_helper is new in 3.9 (pythonGH-…
c6bca2d 
…22618)
@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2020

Thanks @gousaiyang for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2020

GH-22761 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@gousaiyang @miss-islington
Document that test.support.bytecode_helper is new in 3.9 (pythonGH-…
39616ee 
…22618)

(cherry picked from commit cf693e5)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@ambv
Copy link
Contributor

ambv commented Oct 19, 2020

Thanks, @nanjekyejoannah. You're right, if it was added in 3.9, this information belongs in the 3.9 docs, too :-)

nanjekyejoannah pushed a commit that referenced this pull request Oct 19, 2020
@miss-islington @gousaiyang
Document that test.support.bytecode_helper is new in 3.9 (GH-22618) (…
6a9c126 
…GH-22761)

(cherry picked from commit cf693e5)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@gousaiyang @adorilson
Document that test.support.bytecode_helper is new in 3.9 (pythonGH-…
5717283 
…22618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

+1 more reviewer

@Seluj78 Seluj78 Seluj78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gousaiyang @nanjekyejoannah @miss-islington @bedevere-bot @ambv @tirkarthi @Seluj78 @the-knights-who-say-ni