Skip to content

gh-74112: IDLE: Fix blocking function ignore SIGINT #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mlouielu wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

gh-74112: IDLE: Fix blocking function ignore SIGINT #2466

mlouielu wants to merge 5 commits into from

Conversation

@mlouielu
Copy link
Contributor

@mlouielu mlouielu commented Jun 28, 2017 •
edited by bedevere-bot
Loading

@mlouielu @vadmium
bpo-29926: IDLE: Fix blocking function ignore SIGINT
7ce3928 
Co-Authored-By: Martin Panter <vadmium+py@gmail.com>
akruis pushed a commit to akruis/cpython that referenced this pull request Oct 18, 2017
@bitdancer
python#2466: ismount now recognizes mount points user can't access.
750018b 
Patch by Robin Roth, reviewed by Serhiy Storchaka, comment wording
tweaked by me.
akruis pushed a commit to akruis/cpython that referenced this pull request Oct 18, 2017
@bitdancer
Merge: python#2466: ismount now recognizes mount points user can't ac…
c199603 
…cess.
akruis pushed a commit to akruis/cpython that referenced this pull request Oct 18, 2017
@bitdancer
Rewrap long lines in Misc/NEWS.
2a400fd 
Also moved news item for python#2466 to the correct place.
@github-actions
Copy link

github-actions bot commented Feb 20, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
@Mark Mark mannequin mentioned this pull request Apr 10, 2022
Open
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 29, 2022
@hauntsaninja hauntsaninja changed the title bpo-29926: IDLE: Fix blocking function ignore SIGINT gh-74112: IDLE: Fix blocking function ignore SIGINT Jan 7, 2023
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jan 8, 2023
@arhadthedev arhadthedev added stdlib Standard Library Python modules in the Lib/ directory topic-IDLE labels Feb 3, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Feb 3, 2023

Restarting tests because of PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\a\\1\\b\\test\\test_python_2104�\\test_python_worker_876�'.

@arhadthedev
Copy link
Member

arhadthedev commented Feb 3, 2023

Ping @terryjreedy

@terryjreedy terryjreedy self-assigned this Feb 4, 2023
@terryjreedy terryjreedy marked this pull request as draft February 4, 2023 00:39
@terryjreedy
Copy link
Member

terryjreedy commented Feb 4, 2023

I converted this draftl

  1. Patch is based on Martin Panter's bpo diff. Louie's comment: IDLE: in shell, time.sleep ignores _thread.interrupt_main() #74112 (comment). Martin did not approve of the changes: IDLE: in shell, time.sleep ignores _thread.interrupt_main() #74112 (comment).

  2. Other approaches were discussed on the issue as likely better (but without alternate PRs).

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium Awaiting requested review from vadmium

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

@terryjreedy terryjreedy

Labels

awaiting review stale Stale PR or inactive for long period of time. stdlib Standard Library Python modules in the Lib/ directory topic-IDLE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mlouielu @arhadthedev @terryjreedy @brettcannon @the-knights-who-say-ni @ezio-melotti