Skip to content

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Mar 1, 2021

  • Moved down the entries for PEP 563, 604, 612, 613 into the new New Features Related to Type Annotations section. These are pretty esoteric IMO and mostly relate to typing. This will benefit users who aren't interested or don't use type annotations.
  • Moved down point-form new language features Other Language Changes. Originally they were under PEP 563 https://docs.python.org/3.10/whatsnew/3.10.html#pep-563-postponed-evaluation-of-annotations-becomes-default . The old version may have confused users because it's hard to see where it starts (anecdotally, I was confused ;).
  • Place PEP 634 pattern matching last in the New Features section. The section on PEP 634 is rightfully long and it's difficult to discern where it ends and where a new section starts. Mitigated this by placing PEP 634 last.

CC: @pablogsal (release manager), @gvanrossum (for the typing stuff). Please take a look if you have the time. Thanks!

@gvanrossum
Copy link
Member

Hm, I'm not sure I would do it this way.

  • You're right that the three bullets are in the wrong section, but they should just be added to the "Other Language Language Changes" section right below it.
  • I think PEP 604 needs to be grouped with the other typing PEPs, even though it affects isinstance/issubclass.
  • And PEP 563 should also be grouped with these.
  • The four typing PEPs should probably not be subheadings under the 'typing' module but in a separate sectnion about typing-related PEPs, to be added below the list of general PEPs (which currently is just PEP 634).
  • The typing module should then just refer to that section of PEPs.
  • Something I can't do anything about: the CSS currently uses almost the same font size for level 2 and 3 headings (--- and ~~~ in the source). This makes it hard to find the end of a large level 2 section like PEP 634 (patterns).

@Fidget-Spinner
Copy link
Member Author

Points taken about creating a new PEP subsection just for the typing related PEPs. I'll fix it tomorrow. Thanks!

@Fidget-Spinner
Copy link
Member Author

Sorry in advance: the git diff looks pretty horrendous even though I mostly just reshuffled the sections...

  • You're right that the three bullets are in the wrong section, but they should just be added to the "Other Language Language Changes" section right below it.

Done.

  • I think PEP 604 needs to be grouped with the other typing PEPs, even though it affects isinstance/issubclass.
  • And PEP 563 should also be grouped with these.
  • The four typing PEPs should probably not be subheadings under the 'typing' module but in a separate sectnion about typing-related PEPs, to be added below the list of general PEPs (which currently is just PEP 634).

Done, created a new section.

  • The typing module should then just refer to that section of PEPs.

Done.

  • Something I can't do anything about: the CSS currently uses almost the same font size for level 2 and 3 headings (--- and ~~~ in the source). This makes it hard to find the end of a large level 2 section like PEP 634 (patterns).

I tried to work around this by pushing PEP 634 to the bottom of the list for the general PEPs. Otherwise I couldn't discern where the "Better error messages in the parser" section started.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this before a merge conflict happens!

@gvanrossum gvanrossum merged commit 727a68b into python:master Mar 3, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner Fidget-Spinner deleted the cleanup-whatsnew-310 branch March 7, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants