Skip to content

[2.7] bpo-30759: Fix test_multibytecodec_support#2545

Closed
vstinner wants to merge 1 commit intopython:2.7from
vstinner:list_cases27
Closed

[2.7] bpo-30759: Fix test_multibytecodec_support#2545
vstinner wants to merge 1 commit intopython:2.7from
vstinner:list_cases27

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Jul 3, 2017

TestBase_Mapping doesn't inherit from unittest.TestCase anymore, but
object, since it's not a real test case but only a base base. All
child classes already inherit from unittest.TestCase.

TestBase_Mapping doesn't inherit from unittest.TestCase anymore, but
object, since it's not a real test case but only a base base. All
child classes already inherit from unittest.TestCase.
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Jul 3, 2017

Example: test_codecmaps_tw still runs the same 6 tests with this change.

haypo@selma$ ./python -m test -v test_codecmaps_tw
...
test_errorhandle (test.test_codecmaps_tw.TestBIG5Map) ... ok
test_mapping_file (test.test_codecmaps_tw.TestBIG5Map) ... ok
test_mapping_supplemental (test.test_codecmaps_tw.TestBIG5Map) ... ok
test_errorhandle (test.test_codecmaps_tw.TestCP950Map) ... ok
test_mapping_file (test.test_codecmaps_tw.TestCP950Map) ... ok
test_mapping_supplemental (test.test_codecmaps_tw.TestCP950Map) ... ok
...
Ran 6 tests in 2.363s

@serhiy-storchaka
Copy link
Copy Markdown
Member

Yes, this works.

But maybe make the tests more similar to 3.x and just rename test_multibytecodec_support.py to multibytecodec_support.py.

@serhiy-storchaka
Copy link
Copy Markdown
Member

See 75d9aca.

@serhiy-storchaka
Copy link
Copy Markdown
Member

Backported in #2548.

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Jul 3, 2017

Abandonned in favor of @serhiy-storchaka PR #2548.

@vstinner vstinner closed this Jul 3, 2017
@vstinner vstinner deleted the list_cases27 branch July 3, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants