Skip to content

Remove legacy opcache structs#27164

Merged
corona10 merged 2 commits intopython:mainfrom
Fidget-Spinner:remove_old_opcache
Jul 16, 2021
Merged

Remove legacy opcache structs#27164
corona10 merged 2 commits intopython:mainfrom
Fidget-Spinner:remove_old_opcache

Conversation

@Fidget-Spinner
Copy link
Copy Markdown
Member

No description provided.

@Fidget-Spinner Fidget-Spinner changed the title Remove legacy opcache Remove legacy opcache structs Jul 15, 2021
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "pycore_code.h" // _PyOpcache

// _PyOpcache  --> _PyCodeConstructor ?

@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Fidget-Spinner
Copy link
Copy Markdown
Member Author

#include "pycore_code.h" // _PyOpcache

// _PyOpcache  --> _PyCodeConstructor ?

You're right. Thanks for the catch.

@corona10 corona10 merged commit e9cd47d into python:main Jul 16, 2021
@Fidget-Spinner Fidget-Spinner deleted the remove_old_opcache branch July 16, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants