Skip to content

doc: use colon for all color's ranges #28998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

doc: use colon for all color's ranges #28998

merged 1 commit into from
Feb 14, 2022

Conversation

@rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Oct 16, 2021

Replace 12 bit" with 12 bit:, and 16 bitwith 16 bit:, just like 4 bit: and 8 bit:

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 16, 2021
@github-actions
Copy link

github-actions bot commented Nov 16, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 16, 2021
hugovk
hugovk approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is an improvement.

PS Please could you fix the "rangs" -> "ranges" typo in the PR title?

@rffontenelle rffontenelle changed the title doc: use colon for all color's rangs doc: use colon for all color's ranges Jan 29, 2022
@rffontenelle
Copy link
Contributor Author

rffontenelle commented Jan 29, 2022

@hugovk title fixed, thanks

Mariatta
Mariatta approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Mariatta Mariatta merged commit 6b9f27d into python:main Feb 14, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Feb 14, 2022

Thanks @rffontenelle for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Feb 14, 2022

GH-31336 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2022
@rffontenelle @miss-islington
doc: use colon for all color's rangs (pythonGH-28998)
bc4ce92 
(cherry picked from commit 6b9f27d)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2022
@rffontenelle @miss-islington
doc: use colon for all color's rangs (pythonGH-28998)
e9cf20b 
(cherry picked from commit 6b9f27d)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 14, 2022

GH-31337 is a backport of this pull request to the 3.9 branch.

Mariatta pushed a commit that referenced this pull request Feb 14, 2022
@miss-islington @rffontenelle
doc: use colon for all color's rangs (GH-28998) (#31336)
c5a987b 
(cherry picked from commit 6b9f27d)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 14, 2022
@miss-islington @rffontenelle
doc: use colon for all color's rangs (GH-28998)
5c303f3 
(cherry picked from commit 6b9f27d)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @rffontenelle @hello-adam
doc: use colon for all color's rangs (pythonGH-28998)
9f621e8 
(cherry picked from commit 6b9f27d)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@rffontenelle rffontenelle deleted the patch-2 branch April 22, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rffontenelle @miss-islington @bedevere-bot @hugovk @Mariatta @the-knights-who-say-ni