Skip to content

bpo-31027: Fix test_listcomps failure when run directly#2939

Merged
terryjreedy merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-31027-test_listcomps-failure
Jul 29, 2017
Merged

bpo-31027: Fix test_listcomps failure when run directly#2939
terryjreedy merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-31027-test_listcomps-failure

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Jul 29, 2017

counts = [None] * 5
for i in range(len(counts)):
support.run_doctest(test_genexps, verbose)
support.run_doctest(test_listcomps, verbose)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simple copy bug and fix. Given that 'test_genexps' is not defined in the file, it seems like a bug that it passes when run by test.regrtest.

@methane methane added needs backport to 3.6 tests Tests in the Lib/test dir labels Jul 29, 2017
@terryjreedy terryjreedy merged commit ceb93f4 into python:master Jul 29, 2017
terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Jul 29, 2017
…GH-2939)

Bug appears to be incomplete copy-paste-edit.
(cherry picked from commit ceb93f4)
@bedevere-bot
Copy link
Copy Markdown

GH-2945 is a backport of this pull request to the 3.6 branch.

terryjreedy added a commit that referenced this pull request Jul 29, 2017
… (#2945)

Bug appears to be incomplete copy-paste-edit.
(cherry picked from commit ceb93f4)
@ZackerySpytz ZackerySpytz deleted the bpo-31027-test_listcomps-failure branch July 30, 2017 02:13
@serhiy-storchaka
Copy link
Copy Markdown
Member

Thank you @ZackerySpytz for your patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants