Move an unrelated statement out of a try clause in Sequence.index#32330
Merged
rhettinger merged 1 commit intopython:mainfrom Apr 6, 2022
Merged
Move an unrelated statement out of a try clause in Sequence.index#32330rhettinger merged 1 commit intopython:mainfrom
rhettinger merged 1 commit intopython:mainfrom
Conversation
Contributor
|
This is mostly pointless code churn, but I'll accept this one. Please turn your energies to fixing actual known bugs instead of rewriting everything you look at. It is timing consuming and if I miss a subtlety during code review, there is always a risk of introducing a bug in code that has been deployed and stable for a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.