closes bpo-31525: require sqlite3_prepare_v2#3666
Merged
Conversation
This is based on ghaering/pysqlite@40b349c#diff-0489411409cd2934730e88bf7767790, though I believe we can be a bit more aggressive about deleting code.
Member
berkerpeksag
left a comment
There was a problem hiding this comment.
We can also delete the following snippet from Modules/_sqlite/util.c:
#if SQLITE_VERSION_NUMBER < 3003009
/* SQLite often doesn't report anything useful, unless you reset the statement first.
When using sqlite3_prepare_v2 this is not needed. */
if (st != NULL) {
(void)sqlite3_reset(st);
}
#endifCould you also note the minimum SQLite version in the blurb entry?
Member
berkerpeksag
left a comment
There was a problem hiding this comment.
This looks pretty good to me except 2-space indentation in Modules/_sqlite/cursor.c.
berkerpeksag
approved these changes
Sep 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on
ghaering/pysqlite@40b349c#diff-0489411409cd2934730e88bf7767790,
though I believe we can be a bit more aggressive about deleting code.
https://bugs.python.org/issue31525