bpo-31853: Replaced socket.method calls with super() in SSLSocket.#4048
bpo-31853: Replaced socket.method calls with super() in SSLSocket.#4048tiran merged 1 commit intopython:masterfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
2354d0f to
5d78918
Compare
|
@tiran Is there anything stalling this? |
tiran
left a comment
There was a problem hiding this comment.
Sorry, I forgot about your patch. LGTM, please fix indention and I'll merge it later today.
There was a problem hiding this comment.
Should be done. One attribute per line seems to be the style.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
5d78918 to
08075f7
Compare
|
Yeah, it looks fine now. Thanks for your contribution |
|
@tiran: Please replace |
https://bugs.python.org/issue31853