Skip to content

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2017
Merged

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

merged 3 commits into from
Oct 26, 2017

Conversation

@abalkin
Copy link
Member

@abalkin abalkin commented Oct 24, 2017 •
edited by bedevere-bot
Loading

A patch by Mark Gollahon.

https://bugs.python.org/issue28281

@taleinat
Copy link
Contributor

taleinat commented Oct 26, 2017

For reference, this is awaiting documentation improvements, to be done either by the original author or by @abalkin.

Small reminder, @abalkin, to make sure the original author has signed a CLA.

serhiy-storchaka
serhiy-storchaka reviewed Oct 26, 2017
View reviewed changes
Lib/calendar.py Outdated
Copy link
Member

@serhiy-storchaka serhiy-storchaka Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this patch makes years out of range MINYEAR-MAXYEAR be supported.

@abalkin
Copy link
Member Author

abalkin commented Oct 26, 2017

@taleinat - yes, according to the bpo, Mark Gollahon has signed a CLA.

@abalkin abalkin self-assigned this Oct 26, 2017
@abalkin abalkin merged commit 66c88ce into python:master Oct 26, 2017
serhiy-storchaka pushed a commit that referenced this pull request Jan 29, 2024
@planet36
Remove limit in calendar CLI help message for year arg (GH-114719)
0f54ee4 
The limit was removed in 66c88ce (GH-4109).
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2024
@planet36 @miss-islington
Remove limit in calendar CLI help message for year arg (pythonGH-114719)
2a78c3e 
The limit was removed in 66c88ce (pythonGH-4109).
(cherry picked from commit 0f54ee4)

Co-authored-by: Steven Ward <planet36@users.noreply.github.com>
@miss-islington miss-islington mentioned this pull request Jan 29, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2024
@planet36 @miss-islington
Remove limit in calendar CLI help message for year arg (pythonGH-114719)
01098cb 
The limit was removed in 66c88ce (pythonGH-4109).
(cherry picked from commit 0f54ee4)

Co-authored-by: Steven Ward <planet36@users.noreply.github.com>
@miss-islington miss-islington mentioned this pull request Jan 29, 2024
Merged
serhiy-storchaka pushed a commit that referenced this pull request Jan 29, 2024
@miss-islington @planet36
[3.12] Remove limit in calendar CLI help message for year arg (GH-114719
a316470 
) (GH-114722)

The limit was removed in 66c88ce (GH-4109).
(cherry picked from commit 0f54ee4)

Co-authored-by: Steven Ward <planet36@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jan 29, 2024
@miss-islington @planet36
[3.11] Remove limit in calendar CLI help message for year arg (GH-114719
55bddca 
) (GH-114723)

The limit was removed in 66c88ce (GH-4109).
(cherry picked from commit 0f54ee4)

Co-authored-by: Steven Ward <planet36@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@planet36 @aisk
Remove limit in calendar CLI help message for year arg (pythonGH-114719)
f2c8e11 
The limit was removed in 66c88ce (pythonGH-4109).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

@abalkin abalkin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abalkin @taleinat @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot