Skip to content

bpo-32069: Drop legacy SSL transport #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2017
Merged

bpo-32069: Drop legacy SSL transport #4451

merged 4 commits into from
Nov 18, 2017

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Nov 18, 2017 •
edited
Loading

Legacy SSL transports was not used starting from Python 3.5, let's drop never executed code.

https://bugs.python.org/issue32069

@asvetlov asvetlov requested a review from 1st1 as a code owner November 18, 2017 15:10
@asvetlov asvetlov changed the title Drop legacy SSL transport bpo-32069: Drop legacy SSL transport Nov 18, 2017
1st1
1st1 reviewed Nov 18, 2017
View reviewed changes
Lib/test/test_asyncio/test_selector_events.py Outdated

import asyncio
from asyncio import selectors
from asyncio import sslproto
Copy link
Member

@1st1 1st1 Nov 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this new import?

Copy link
Contributor Author

@asvetlov asvetlov Nov 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was my mistake, dropped.

@asvetlov asvetlov merged commit 51d546a into python:master Nov 18, 2017
@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2017

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@asvetlov asvetlov deleted the drop-wrap_socket branch November 18, 2017 16:54
@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2017

GH-4453 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2017
@asvetlov @miss-islington
bpo-32069: Drop legacy SSL transport (pythonGH-4451)
05ac7f3 
* Drop legacy SSL transport

* Drop unused import

* Fix Windows tests

* Drop never executed on Python 3.4+ code
(cherry picked from commit 51d546a)
@1st1
Copy link
Member

1st1 commented Nov 18, 2017

Hey, this must not be merged to 3.6

@asvetlov
Copy link
Contributor Author

asvetlov commented Nov 18, 2017 •
edited
Loading

Why?
The code in 3.6 will still keep working, nobody will see the change!
If you strongly disagree I'll make a revert commit but please tell me why?
All changes are for dropping 3.4 only features.

@1st1
Copy link
Member

1st1 commented Nov 18, 2017

3.6 is in a bug fix mode. Removing any APIs does not match that, unless it’s a critical security issue.

Maybe someone is importing/using these APIs manually. Breaking their code (however wrong it is) in a bugfix release is not an option.

@asvetlov
Copy link
Contributor Author

asvetlov commented Nov 18, 2017

I've got your point.
Closing #4453

@asvetlov
Copy link
Contributor Author

asvetlov commented Nov 18, 2017

Thanks for pointing on the problem.

@1st1
Copy link
Member

1st1 commented Nov 18, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asvetlov @miss-islington @bedevere-bot @1st1 @the-knights-who-say-ni