bpo-29040: Support building Android with Unified Headers #4492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first NDK release to support Unified Headers is android-ndk-r14.
yan12125
reviewed
Nov 21, 2017
Include/pyport.h
Outdated
|
|
||
| #ifdef __ANDROID__ | ||
| #include <android/api-level.h> | ||
| /* nl_langinfo() is declared as __INTRODUCED_IN_FUTURE in langinfo.h. */ |
Contributor
There was a problem hiding this comment.
Should be better as:
In NDK r14 nl_langinfo() is declared as __INTRODUCED_IN_FUTURE in langinfo.h.
As a side note, since NDK r15, nl_langinfo() is declared as __INTRODUCED_IN(26).
yan12125
added a commit
to yan12125/python3-android
that referenced
this pull request
Nov 24, 2017
xdegaye fixes the same problem with a simpler approach [1]. Not sure if that will break applications on API 26 or not (Android O, Oreo) [1] python/cpython#4492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first NDK release to support Unified Headers is android-ndk-r14.
https://bugs.python.org/issue29040