Move footnote marker closer to the related term, before sentence's ending dot#4518
Conversation
| Let's create an extension module called ``spam`` (the favorite food of Monty | ||
| Python fans...) and let's say we want to create a Python interface to the C | ||
| library function :c:func:`system`. [#]_ This function takes a null-terminated | ||
| library function :c:func:`system`\ [#]_. This function takes a null-terminated |
There was a problem hiding this comment.
The \ is not needed. It should just be:
:c:func:`system` [#]_.
| Forgetting to dispose of an owned reference creates a memory leak. | ||
|
|
||
| It is also possible to :dfn:`borrow` [#]_ a reference to an object. The | ||
| It is also possible to :dfn:`borrow`\ [#]_ a reference to an object. The |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Mariatta
left a comment
Mariatta
left a comment
There was a problem hiding this comment.
The earlier change request was so trivial, I made the change myself to your branch :) Hope that's ok.
Everything else looks good. Once CI passed, this should be good to merge.
Move footnote markers to be closer to the related terminology: before the end of the sentence, instead of after. (cherry picked from commit cdfe910)
|
GH-4535 is a backport of this pull request to the 3.6 branch. |
|
Thanks @lelit and congrats on your first contribution to CPython 🌮 |
|
GH-4536 is a backport of this pull request to the 2.7 branch. |
Move footnote markers to be closer to the related terminology: before the end of the sentence, instead of after. (cherry picked from commit cdfe910)
|
Thank you! |
5 participants
This cures a minor aesthetic issue in the Extending Python section of the documentation.