Skip to content

Add Guido and Ivan as owners for typing.py#4729

Merged
ned-deily merged 2 commits into
masterfrom
typing-owners
Dec 5, 2017
Merged

Add Guido and Ivan as owners for typing.py#4729
ned-deily merged 2 commits into
masterfrom
typing-owners

Conversation

@gvanrossum
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum commented Dec 5, 2017

ilevkivskyi
ilevkivskyi reviewed Dec 5, 2017
View reviewed changes
Comment thread .github/CODEOWNERS Outdated

**/*idlelib* @terryjreedy

**/*typing* @gvanrossum @ilevkivslyi
Copy link
Copy Markdown
Member

@ilevkivskyi ilevkivskyi Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR! There is a small typo: it should be @ilevkivskyi (the third letter from the end should be k, not l).

Copy link
Copy Markdown
Member Author

@gvanrossum gvanrossum Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang. And I was trying to be so careful! :-) Fixed now.

@ned-deily ned-deily merged commit 5e8cbcc into master Dec 5, 2017
@ned-deily ned-deily deleted the typing-owners branch December 5, 2017 21:56
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 5, 2017

Thanks @gvanrossum for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 5, 2017

Sorry, @gvanrossum and @ned-deily, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5e8cbcc4f25dcdc02651414f792dc4a546ba199b 3.6

@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Dec 5, 2017

Codeowners is only in master branch. Do we need it in the other branches?

@gvanrossum
Copy link
Copy Markdown
Member Author

gvanrossum commented Dec 5, 2017

Let's not.

@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented Dec 5, 2017

Having it only with master is fine with me, I didn't realize it was only there. So no backport needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gvanrossum @miss-islington @Mariatta @ned-deily @ilevkivskyi @the-knights-who-say-ni @bedevere-bot