Skip to content

bpo-32256: Make patchcheck.py work for out-of-tree builds #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Oct 20, 2018
Merged

bpo-32256: Make patchcheck.py work for out-of-tree builds #4760

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f6cd0c
bpo-32256: Make patchcheck.py work for out-of-tree builds
Dec 9, 2017
03b8863
Add NEWS entry
Feb 28, 2018
210bc96
Delete 2018-02-28-13-17-36.bpo-32256.cT-jhI.rst
berkerpeksag Aug 24, 2018
9a9739d
Merge branch 'master' into bpo-32256
berkerpeksag Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Tools/scripts/patchcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ def get_git_branch():
"""Get the symbolic name for the current git branch"""
cmd = "git rev-parse --abbrev-ref HEAD".split()
try:
return subprocess.check_output(cmd, stderr=subprocess.DEVNULL)
return subprocess.check_output(cmd,
stderr=subprocess.DEVNULL,
cwd=SRCDIR)
except subprocess.CalledProcessError:
return None

Expand All @@ -60,7 +62,9 @@ def get_git_upstream_remote():
"""
cmd = "git remote get-url upstream".split()
try:
subprocess.check_output(cmd, stderr=subprocess.DEVNULL)
subprocess.check_output(cmd,
stderr=subprocess.DEVNULL,
cwd=SRCDIR)
except subprocess.CalledProcessError:
return "origin"
return "upstream"
Expand Down Expand Up @@ -98,7 +102,9 @@ def changed_files(base_branch=None):
else:
cmd = 'git status --porcelain'
filenames = []
with subprocess.Popen(cmd.split(), stdout=subprocess.PIPE) as st:
with subprocess.Popen(cmd.split(),
stdout=subprocess.PIPE,
cwd=SRCDIR) as st:
for line in st.stdout:
line = line.decode().rstrip()
status_text, filename = line.split(maxsplit=1)
Expand Down