Skip to content

bpo-19678: Pass channel parameter to process_message #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CuriousLearner wants to merge 1 commit into from
Closed

bpo-19678: Pass channel parameter to process_message #5050

CuriousLearner wants to merge 1 commit into from

Conversation

@CuriousLearner
Copy link
Member

@CuriousLearner CuriousLearner commented Dec 30, 2017 •
edited by bedevere-bot
Loading

Uses inspect.signature to know if the process_message method in base class accepts kwargs. If so, we also pass the channel to it.

https://bugs.python.org/issue19678

https://bugs.python.org/issue19678

@CuriousLearner CuriousLearner requested a review from a team as a code owner December 30, 2017 14:41
@willingc willingc self-requested a review October 7, 2018 09:26
@vstinner
Copy link
Member

vstinner commented Nov 22, 2018

@warsaw closed the issue, I close the PR. https://bugs.python.org/issue19678#msg309744

@vstinner vstinner closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc Awaiting requested review from willingc

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CuriousLearner @vstinner @the-knights-who-say-ni @bedevere-bot