Skip to content

bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference#6454

Merged
orsenthil merged 1 commit intopython:masterfrom
andresdelfino:urlretrieve_remove
Apr 16, 2018
Merged

bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference#6454
orsenthil merged 1 commit intopython:masterfrom
andresdelfino:urlretrieve_remove

Conversation

@andresdelfino
Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino commented Apr 11, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Apr 11, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@andresdelfino andresdelfino changed the title bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference [skip news] Apr 11, 2018
@andresdelfino andresdelfino changed the title bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference [skip news] bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference Apr 11, 2018
@andresdelfino andresdelfino changed the title bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference x Apr 12, 2018
@andresdelfino andresdelfino changed the title bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference x bpo-33264: Remove might-be-deprecated urllib.request.urlretrieve function reference Apr 12, 2018
@orsenthil orsenthil merged commit c89b221 into python:master Apr 16, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 16, 2018

Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 16, 2018

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2018
@andresdelfino @miss-islington
Remove to-be-deprecated urllib.request.urlretrieve function reference (…
5123b85 
…pythonGH-6454)

(cherry picked from commit c89b221)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 16, 2018

GH-6486 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2018
@andresdelfino @miss-islington
Remove to-be-deprecated urllib.request.urlretrieve function reference (…
4b858b4 
…pythonGH-6454)

(cherry picked from commit c89b221)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 16, 2018

GH-6487 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Apr 16, 2018
@miss-islington @andresdelfino
Remove to-be-deprecated urllib.request.urlretrieve function reference (…
f20eca7 
…GH-6454)

(cherry picked from commit c89b221)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 16, 2018
@miss-islington @andresdelfino
Remove to-be-deprecated urllib.request.urlretrieve function reference (…
ab99475 
…GH-6454)

(cherry picked from commit c89b221)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
@andresdelfino andresdelfino deleted the urlretrieve_remove branch April 16, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andresdelfino @the-knights-who-say-ni @miss-islington @bedevere-bot @orsenthil @zware