[2.7] bpo-33513: Fixed incorrect version linux detection (platform.py)#6855
Closed
mrandybu wants to merge 2 commits intopython:2.7from
Closed
[2.7] bpo-33513: Fixed incorrect version linux detection (platform.py)#6855mrandybu wants to merge 2 commits intopython:2.7from
mrandybu wants to merge 2 commits intopython:2.7from
Conversation
vstinner
requested changes
May 17, 2018
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
See discussion at https://bugs.python.org/issue33513
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some linux distributions, the information about the distribution is incorrectly determined when the linux_distribution() method is called from the platform class. Since the information file os-release becomes a certain standard, I propose first of all to check its availability and if it is in the system - parse the information from it.
https://bugs.python.org/issue33513