bpo-33554: make_keys_shared reusing oldkeys memory#6932
bpo-33554: make_keys_shared reusing oldkeys memory#6932br0wn9 wants to merge 2 commits intopython:masterfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
|
Already set github username |
|
I've just signed CLA, please recheck it. |
| /* Remove dummy keys */ | ||
| if (dictresize(mp, DK_SIZE(mp->ma_keys))) | ||
| return NULL; | ||
| clear_dummy_keys(mp); |
| second = entries + 1; | ||
| end = entries + numentries; | ||
|
|
||
| for( ;; ) { |
There was a problem hiding this comment.
Use for (;;) { or while (1) {.
We always insert space outer parens, not inner.
5 participants
bpo-33554: make_keys_shared reusing oldkeys memory
https://bugs.python.org/issue33554