Skip to content

bpo-33595: Fix lambda parameters being refered as arguments#7037

Merged
JulienPalard merged 1 commit into
python:masterfrom
andresdelfino:lambda-arguments
May 22, 2018
Merged

bpo-33595: Fix lambda parameters being refered as arguments#7037
JulienPalard merged 1 commit into
python:masterfrom
andresdelfino:lambda-arguments

Conversation

@andresdelfino
Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino commented May 21, 2018

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2018
(cherry picked from commit 268cc7c)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-7040 is a backport of this pull request to the 3.7 branch.

@JulienPalard
Copy link
Copy Markdown
Member

@andresdelfino Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2018
(cherry picked from commit 268cc7c)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-7041 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 22, 2018
(cherry picked from commit 268cc7c)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request May 22, 2018
(cherry picked from commit 268cc7c)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the lambda-arguments branch May 22, 2018 11:48
@andresdelfino
Copy link
Copy Markdown
Contributor Author

Should I cherry-pick the commit to backport the fix to 2.7?

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino and @JulienPalard, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 268cc7c3f8f58075b42ff0cd6b6c6c5d76044895 2.7

@bedevere-bot
Copy link
Copy Markdown

GH-7122 is a backport of this pull request to the 2.7 branch.

@terryjreedy
Copy link
Copy Markdown
Member

Julien, The commit message did not have the "bpo-33595: " prefix. Hence the backports were missing the prefixes. Hence the backports were not listed on the issue, and one could not tell from the issue that the backports had been done.

Andres, I added a 2.7 backport label, but there is a conflict. While checking why (the function name in the def equivalent), I made the changes and 2.7 PR.

terryjreedy added a commit that referenced this pull request May 25, 2018
…-7037) (GH-7122)

(cherry picked from commit 268cc7c)

Co-authored-by: Andrés Delfino adelfino@gmail.com
@terryjreedy
Copy link
Copy Markdown
Member

Andrés, it appears that you created the PR without the bpo prefix, and that it was added later (due to the CI message). Unfortunately, Github's default title for commits is the original PR title, not the corrected title.

@andresdelfino
Copy link
Copy Markdown
Contributor Author

Yes, that is exactly what happened!

@JulienPalard
Copy link
Copy Markdown
Member

@terryjreedy woops I in fact missed this point, sorry for this. I followed closely https://devguide.python.org/committing/#is-the-pr-ready-to-be-accepted but jumped a bit fast on the "squash and merge", overlooking https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request, my bad.

@terryjreedy
Copy link
Copy Markdown
Member

I consider it a Github bug that it resurrects the initial version of the title to use as the default merge title. I still occasionally forget to replace '#' with 'GH-', so I now make myself pause between initial and confirmatory clicks. Slower can be faster ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants