bpo-33860: Prefer "OrderedDict" over "ordered dictionary"#7535
Closed
andresdelfino wants to merge 1 commit intopython:masterfrom
Closed
bpo-33860: Prefer "OrderedDict" over "ordered dictionary"#7535andresdelfino wants to merge 1 commit intopython:masterfrom
andresdelfino wants to merge 1 commit intopython:masterfrom
Conversation
Member
|
Please, open an issue in http://bugs.python.org and reference that issue number in the pull request title. More info about the workflow: https://devguide.python.org/pullrequest/#submitting Thanks! :) |
andresdelfino
changed the title
Contributor
Author
|
Issue created :) I merged #7538 into this, because the motivation is the same. |
andresdelfino
changed the title
Member
|
This feels like an unnecessary change. The phrase "ordered dictionary" does not always refer to an 'OrderedDict`, and there is more than one way to order a dictionary besides insertion order. As a side note: it's generally better to have different pull requests for different modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clear that the members special attribute of enums is an OrderedDict, now that "ordered dictionaries" can be somewhat confusing with insertion order being preserved by dict.
https://bugs.python.org/issue33860