Skip to content

bpo-33460: remove ellipsis that look like continuation prompts#7851

Merged
gpshead merged 2 commits intopython:masterfrom
lew18:master
Sep 11, 2018
Merged

bpo-33460: remove ellipsis that look like continuation prompts#7851
gpshead merged 2 commits intopython:masterfrom
lew18:master

Conversation

@lew18
Copy link
Copy Markdown
Contributor

@lew18 lew18 commented Jun 21, 2018 •
edited by bedevere-bot
Loading

has side benefit of putting rest of error message in proper text color.

https://bugs.python.org/issue33460

@lew18
bpo-33460: remove ellipsis that look like continuation prompts
bfc59d8 
has side benefit of putting rest of error message in proper text color.
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jun 21, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@lew18
Copy link
Copy Markdown
Contributor Author

lew18 commented Jun 21, 2018

Apologies, I signed the CLA just 15 minutes ago...only another 23 hours at 45 minutes to wait. -Lew

@lew18
Copy link
Copy Markdown
Contributor Author

lew18 commented Jul 17, 2018

Carreau, Thank you for reviewing. -Lew

@gpshead gpshead merged commit f019579 into python:master Sep 11, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 11, 2018

Thanks @lew18 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2018
@lew18 @miss-islington
bpo-33460: remove ellipsis that look like continuation prompts (pytho…
ca34bcf 
…nGH-7851)

Remove ellipsis that look like continuation prompts,
has a side benefit of putting rest of error message in proper text color.
(cherry picked from commit f019579)

Co-authored-by: Lew Kurtz <37632626+lew18@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2018

GH-9152 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2018
@miss-islington @lew18
bpo-33460: remove ellipsis that look like continuation prompts (GH-7851)
037582e 
Remove ellipsis that look like continuation prompts,
has a side benefit of putting rest of error message in proper text color.
(cherry picked from commit f019579)

Co-authored-by: Lew Kurtz <37632626+lew18@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Carreau Carreau Carreau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lew18 @the-knights-who-say-ni @miss-islington @bedevere-bot @Carreau @gpshead