bpo-34239: Convert test_bz2 to use tempfile#8485
Merged
tjguk merged 2 commits intopython:masterfrom Jul 26, 2018
tjguk:Issue34329-test_bz2
Merged
bpo-34239: Convert test_bz2 to use tempfile#8485tjguk merged 2 commits intopython:masterfrom tjguk:Issue34329-test_bz2
tjguk merged 2 commits intopython:masterfrom
tjguk:Issue34329-test_bz2
Conversation
test_bz2 currently uses the test.support.TESTFN functionality which creates a temporary file local to the test directory named around the pid. This can give rise to race conditions where tests are competing with each other to delete and recreate the file. This change converts the tests to use tempfile.mkstemp which gives a different file every time from the system's temp area
pfmoore
approved these changes
Jul 26, 2018
Member
pfmoore
left a comment
pfmoore
left a comment
There was a problem hiding this comment.
LGTM. As an approach, this seems fine, although it's possible that a test that expects the file to not exist in advance could fail if changed to use this approach. That would be fairly easy to spot and fix on a case by case basis, though.
Member
Author
|
@tjguk: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Creating tentatively to see how the non-Windows tests run]
test_bz2 currently uses the test.support.TESTFN functionality which creates a temporary file local to the test directory named around the pid.
This can give rise to race conditions where tests are competing with each other to delete and recreate the file.
This change converts the tests to use tempfile.mkstemp which gives a different file every time from the system's temp area
https://bugs.python.org/issue34239