Skip to content

bpo-33989: Ensure that ms.key_compare is always initialized in list_sort_impl()#8710

Merged
serhiy-storchaka merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-33989-init-key_compare-list-sort
Feb 21, 2019
Merged

bpo-33989: Ensure that ms.key_compare is always initialized in list_sort_impl()#8710
serhiy-storchaka merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-33989-init-key_compare-list-sort

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Aug 9, 2018 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka requested changes Oct 12, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2018-08-08-20-52-55.bpo-33989.TkLBui.rst Outdated
@@ -0,0 +1,2 @@
Ensure that ``ms.key_compare`` is always initialized in :meth:`list.sort`.
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tells nothing to the end user. ms.key_compare is internal name in C sources.

Describe the issue how it can be visible to the end Python or C API user. For example: "Fixed possible crash in list.sort when sort objects with ob_type->tp_richcompare == NULL".

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Oct 12, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented Feb 19, 2019

❗️ @ZackerySpytz Please address Serhiy's comments to help move this pull request along. Thank you!

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Feb 19, 2019
@ZackerySpytz
Copy link
Copy Markdown
Contributor Author

ZackerySpytz commented Feb 21, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 21, 2019

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka merged commit ebc793d into python:master Feb 21, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 21, 2019

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2019
@ZackerySpytz @miss-islington
bpo-33989: Ensure that ms.key_compare is always initialized in list_s…
ee4070e 
…ort_impl(). (pythonGH-8710)

(cherry picked from commit ebc793d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 21, 2019

GH-11970 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 21, 2019
@miss-islington @ZackerySpytz
bpo-33989: Ensure that ms.key_compare is always initialized in list_s…
0e73ea2 
…ort_impl(). (GH-8710)

(cherry picked from commit ebc793d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @bedevere-bot @csabella @miss-islington @serhiy-storchaka @the-knights-who-say-ni