Skip to content

[3.7] bpo-34565: Change a PC/launcher.c comment to accurately describe valid major versions. (GH-9037) #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ned-deily merged 1 commit into from
Oct 6, 2018
Merged

[3.7] bpo-34565: Change a PC/launcher.c comment to accurately describe valid major versions. (GH-9037) #9065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PC/launcher.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@ static BOOL
validate_version(wchar_t * p)
{
/*
Version information should start with one of 2 or 3,
Version information should start with the major version,
Optionally followed by a period and a minor version,
Optionally followed by a minus and one of 32 or 64.
Valid examples:
Expand All @@ -1068,7 +1068,7 @@ validate_version(wchar_t * p)
*/
BOOL result = (p != NULL); /* Default to False if null pointer. */

result = result && iswdigit(*p); /* Result = False if fist string element is not a digit. */
result = result && iswdigit(*p); /* Result = False if first string element is not a digit. */

while (result && iswdigit(*p)) /* Require a major version */
++p; /* Skip all leading digit(s) */
Expand Down