gh-88546: Make new paragraph for emphasis and reordered sentence #91614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slateny
changed the title
slateny
commented
May 2, 2022
| not by actually invoking a subshell. | ||
|
|
||
| Note that files beginning with a dot (``.``) can only be matched by :mod:`glob` | ||
| patterns that also start with a dot, |
Contributor
Author
There was a problem hiding this comment.
This could optionally be a bit more explicit, like
'... patterns that also start with a dot (so *. will not match), unlike ...'
Member
There was a problem hiding this comment.
I think this is clear enough as is.
JelleZijlstra
approved these changes
May 2, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, I have one small suggestion which I'll apply myself
| not by actually invoking a subshell. | ||
|
|
||
| Note that files beginning with a dot (``.``) can only be matched by :mod:`glob` | ||
| patterns that also start with a dot, |
Member
There was a problem hiding this comment.
I think this is clear enough as is.
JelleZijlstra
added
needs backport to 3.9
needs backport to 3.10
Contributor
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
…eordered sentence (pythonGH-91614) (cherry picked from commit b9ab6ce) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
|
GH-92156 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
…eordered sentence (pythonGH-91614) (cherry picked from commit b9ab6ce) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
|
GH-92157 is a backport of this pull request to the 3.9 branch. |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…eordered sentence (pythonGH-91614) (cherry picked from commit b9ab6ce) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#88546
Also added a bit on
Path.glob()