gh-91783: Document security considerations for shutil.unpack_archive #91844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimshady621
reviewed
May 2, 2022
JelleZijlstra
approved these changes
May 2, 2022
JelleZijlstra
added
needs backport to 3.9
needs backport to 3.10
|
Thanks @dignissimus for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
…chive (pythonGH-91844) (cherry picked from commit 4b297a9) Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
|
GH-92165 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
removed
needs backport to 3.10
|
GH-92166 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
May 2, 2022
miss-islington
added a commit
that referenced
this pull request
May 2, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…chive (pythonGH-91844) (cherry picked from commit 4b297a9) Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a warning to the documentation for
shutil.unpack_archivenoting that it is unsafe to unpack archives from untrusted sources. This is done in line with the documentation fromZipfile.extractallandTarFile.extractall.Resolves #91783